add setting to toggle joining vc on room click#102
Closed
RasmusAntons wants to merge 1 commit into
Closed
Conversation
Member
|
What if it required double clicking the room to join it instead, would that solve your problem? Double clicking within a period joins room, otherwise it shows the prescreening view. |
Author
|
That would solve the issue, but I don't know if that would feel intuitive. As far as I know that would be the only double click action anywhere in Sable? Clicking the "Join" button once to join feels pretty reasonable to me. |
Member
|
Hey, if you'd still like to add this could you update your fork to dev, move the setting into the new Call section in general, and add a changeset? |
Member
|
Will mark it as a draft, as there hasn't been activity in the last week, and it has open merge conflicts. Feel free to mark it as ready once these are fixed :3 |
Member
|
Superseded by #768 because the pr has been inactive for 2 months |
8 tasks
Just-Insane
pushed a commit
to Just-Insane/Sable
that referenced
this pull request
May 13, 2026
<!-- Please read https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before submitting your pull request --> ### Description Add the ability to resize the room sidebar, you can either do it in settings as a number of the width of it, or using a hoverable thing. Additionally you can now set whether and when do you want to show the room's icon instead of the default symbol, mainly meant for when the sidebar is not wide enough to display meaningful names to serve as an aid to know which room you are in. A good %age of the changes are just indentation from adding/removing one object (example of holding the bar to drag it) <img width="1033" height="1080" alt="image" src="https://github.com/user-attachments/assets/d7c6f47a-40a6-4199-9258-00f89119afd3" /> (example of smart looks) <img width="1033" height="1080" alt="image" src="https://github.com/user-attachments/assets/287ae643-1178-44b8-96e1-436185c93076" /> <img width="1060" height="1080" alt="image" src="https://github.com/user-attachments/assets/3d915210-fa77-4844-8ce3-64afc244ae8c" /> (settings added here) <img width="810" height="697" alt="image" src="https://github.com/user-attachments/assets/fe925a68-63d7-4ad7-9c90-31243dd386d0" /> <img width="811" height="823" alt="image" src="https://github.com/user-attachments/assets/c2266459-af86-4168-b8e5-aabacb057476" /> (example of the threads being resizeable) <img width="918" height="1080" alt="image" src="https://github.com/user-attachments/assets/d41d6749-489d-46ed-aa78-73aa54af8915" /> <img width="930" height="1080" alt="image" src="https://github.com/user-attachments/assets/07677474-0ef3-4708-8eba-a64a68eac61c" /> <img width="816" height="1080" alt="image" src="https://github.com/user-attachments/assets/23efa84d-c2e4-474b-a85f-d12fadc62b56" /> Fixes: SableClient#68 SableClient#102 SableClient#681 SableClient#694 #### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ### Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] My changes generate no new warnings ### AI disclosure: - [ ] Partially AI assisted (clarify which code was AI assisted and briefly explain what it does). - [ ] Fully AI generated (explain what all the generated code does in moderate detail). <!-- Write any explanation required here, but do not generate the explanation using AI!! You must prove you understand what the code in this PR does. --> The Pisan cats have helped me implement this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added one setting that lets the user disable the behavior of immediately joining a voice call when clicking the NavButton. I personally am stupid and will accidentally join a voice sometimes call which is very embarrassing.
I'm not sure if the settings hierarchy is what you have in mind, if not feel free to make changes or close this PR and implement something like this yourselves.
Type of change
Checklist: